fix(payment): consume first recharge offer after payment

src/app/chat/hooks/use-first-recharge-offer-banner.ts

@@ -38,6 +38,8 @@ interface DismissalState {
   dismissed: boolean;
 }
 
+const FIRST_RECHARGE_DEFAULT_DISCOUNT_PERCENT = 50;
+
 export function shouldShowFirstRechargeOfferBanner(
   input: FirstRechargeOfferBannerEligibility,
 ): boolean {
@@ -66,7 +68,7 @@ export function useFirstRechargeOfferBanner({
     loaded: false,
     dismissed: false,
   }));
-  const discountPercent = payment.firstRechargeOffer?.discountPercent ?? 50;
+  const discountPercent = FIRST_RECHARGE_DEFAULT_DISCOUNT_PERCENT;
 
   useEffect(() => {
     if (!isAuthenticatedUser) return;

src/app/subscription/__tests__/subscription-screen.helpers.test.ts

@@ -174,7 +174,6 @@ describe("subscription screen helpers", () => {
     expect(
       getFirstRechargeOfferView({
         isFirstRecharge: true,
-        discountPercent: 50,
         vipPlans: vipViews,
         coinPlans: coinViews,
       }),
@@ -182,6 +181,13 @@ describe("subscription screen helpers", () => {
       badgeText: "50% OFF",
       title: "First Recharge Offer",
     });
+    expect(
+      getFirstRechargeOfferView({
+        isFirstRecharge: false,
+        vipPlans: vipViews,
+        coinPlans: coinViews,
+      }),
+    ).toBeNull();
   });
 
   it("selects the first VIP plan by default when VIP can be purchased", () => {

src/app/subscription/subscription-screen.helpers.ts

@@ -157,17 +157,17 @@ export function getDefaultSubscriptionPlanId(input: {
 
 export function getFirstRechargeOfferView(input: {
   isFirstRecharge: boolean;
-  discountPercent?: number | null;
   vipPlans: readonly VipOfferPlanView[];
   coinPlans: readonly CoinsOfferPlanView[];
 }): FirstRechargeOfferView | null {
+  if (!input.isFirstRecharge) return null;
+
   const promotedPlan = [...input.vipPlans, ...input.coinPlans].find(
     (plan) => plan.isFirstRechargeOffer,
   );
-  if (!input.isFirstRecharge && !promotedPlan) return null;
 
   const discountPercent =
-    promotedPlan?.firstRechargeDiscountPercent ?? input.discountPercent ?? 50;
+    promotedPlan?.firstRechargeDiscountPercent ?? 50;
   const badgeText = `${discountPercent}% OFF`;
   return {
     badgeText,

src/app/subscription/subscription-screen.tsx

@@ -77,16 +77,10 @@ export function SubscriptionScreen({
     () =>
       getFirstRechargeOfferView({
         isFirstRecharge: payment.isFirstRecharge,
-        discountPercent: payment.firstRechargeOffer?.discountPercent,
         vipPlans: vipOfferPlans,
         coinPlans: directCoinsPlans,
       }),
-    [
-      directCoinsPlans,
-      payment.firstRechargeOffer?.discountPercent,
-      payment.isFirstRecharge,
-      vipOfferPlans,
-    ],
+    [directCoinsPlans, payment.isFirstRecharge, vipOfferPlans],
   );
 
   const selectedPlan = findSelectedSubscriptionPlan({