refactor(routes): move shared pages to global scope

src/router/__tests__/route-meta.test.ts

@@ -4,7 +4,7 @@ import { getRouteAccess, isInternalRoute } from "../route-meta";
 import { ALL_STATIC_ROUTES, getCharacterRoutes, ROUTES } from "../routes";
 
 describe("route meta", () => {
-  it("classifies static routes by access level", () => {
+  it("classifies global routes by access level", () => {
     expect(getRouteAccess(ROUTES.splash)).toBe("authOnly");
     expect(getRouteAccess(ROUTES.auth)).toBe("authOnly");
     expect(getRouteAccess(ROUTES.chat)).toBe("guestEntry");
@@ -23,13 +23,22 @@ describe("route meta", () => {
 
   it("classifies character-scoped routes by their page", () => {
     const routes = getCharacterRoutes("maya");
+    expect(routes).toEqual({
+      splash: "/characters/maya/splash",
+      chat: "/characters/maya/chat",
+      privateRoom: "/characters/maya/private-room",
+      tip: "/characters/maya/tip",
+    });
     expect(getRouteAccess(routes.splash)).toBe("authOnly");
     expect(getRouteAccess(routes.chat)).toBe("guestEntry");
     expect(getRouteAccess(routes.privateRoom)).toBe("guestEntry");
     expect(getRouteAccess(routes.tip)).toBe("public");
-    expect(getRouteAccess(routes.sidebar)).toBe("session");
-    expect(getRouteAccess(routes.feedback)).toBe("session");
-    expect(getRouteAccess(routes.coinsRules)).toBe("public");
+  });
+
+  it("does not classify removed character-scoped global pages", () => {
+    expect(getRouteAccess("/characters/maya/sidebar")).toBe("public");
+    expect(getRouteAccess("/characters/maya/feedback")).toBe("public");
+    expect(getRouteAccess("/characters/maya/coins-rules")).toBe("public");
   });
 
   it("includes private room in static routes", () => {